Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PropfindError exception #753

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

devmount
Copy link
Collaborator

Description of the Change

This adds exception handling for caldav PropfindErrors.

Applicable Issues

Fixes #748

Copy link
Collaborator Author

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved some comments above the corresponding exception, hope that's ok. I find it more readable like this.

backend/src/appointment/controller/calendar.py Outdated Show resolved Hide resolved
@devmount devmount self-assigned this Nov 19, 2024
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

backend/src/appointment/controller/calendar.py Outdated Show resolved Hide resolved
@devmount devmount merged commit b179c44 into main Nov 19, 2024
4 checks passed
@devmount devmount deleted the bugs/748-handle-propfind-errors branch November 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch and return useful error messages for propfinderrors
2 participants