Validate booking slot's weekday in schedule timezone. (Fixes #735) #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
approved these changes
Nov 18, 2024
Co-authored-by: Andreas <[email protected]>
MelissaAutumn
had a problem deploying
to
staging
GitHub Actions
Error
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #735
Fixes a case where the date could overflow to a day of the week which the schedule has disabled. Which would fail booking slot validation.
This is because days of the week are saved based on the user/schedule's timezone rather than UTC. Which is a little confusing and we should maybe look into fixing that, but this is a quick fix for now.