Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components elements TypeScript #577

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Components elements TypeScript #577

merged 8 commits into from
Jul 26, 2024

Conversation

devmount
Copy link
Collaborator

@devmount devmount commented Jul 23, 2024

Description of the Change

This change adds types for all Vue components in elements/* and views/admin/*.

  • The script section was moved to the top in the vue files
  • A bug was fixed where data tables showed the paginated instead of the total number of entries
  • A bug was fixed where data table top and bottom areas had a wrong background color

Applicable Issues

Implements #413

@devmount devmount self-assigned this Jul 23, 2024
Copy link
Collaborator Author

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second part for typing all components in the elements directory. I already started to set lang="ts" on some view components, I will properly type them in a future PR. Just wanted to already use some types without keeping deprecated stuff.

This needs to be tested with FTUE! Or is there a simple way to retrigger the FTUE dialog? I thought there was some flag somewhere 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I threw away appointmentState since this was a relic from the past.

frontend/src/elements/AppointmentGridItem.vue Outdated Show resolved Hide resolved
@devmount devmount requested a review from MelissaAutumn July 23, 2024 19:26
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things but looks good! I haven't done a run through but it looks good.

frontend/src/elements/AppointmentGridItem.vue Outdated Show resolved Hide resolved
frontend/src/models.ts Show resolved Hide resolved
@devmount devmount merged commit 2ab14b1 into main Jul 26, 2024
4 checks passed
@devmount devmount deleted the enhancements/413-elements-ts branch July 26, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants