-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components elements TypeScript #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the second part for typing all components in the elements directory. I already started to set lang="ts"
on some view components, I will properly type them in a future PR. Just wanted to already use some types without keeping deprecated stuff.
This needs to be tested with FTUE! Or is there a simple way to retrigger the FTUE dialog? I thought there was some flag somewhere 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I threw away appointmentState
since this was a relic from the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things but looks good! I haven't done a run through but it looks good.
Description of the Change
This change adds types for all Vue components in
elements/*
andviews/admin/*
.Applicable Issues
Implements #413