Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/448 health check v2 #489

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Conversation

MelissaAutumn
Copy link
Member

@MelissaAutumn MelissaAutumn commented Jun 13, 2024

The healthcheck will now return 503's if MySQL or Redis (If configured) are missing. Otherwise you'll get a 200 Health OK message. Technically this message is localized so it ensures locale is working as well. Since the default locale is English, it should say "Health OK". No need to check that though.

This also fixes a local config issue with redis, and tests accidentally inheriting "None" values from your main .env.

@MelissaAutumn MelissaAutumn requested a review from jdbass June 13, 2024 20:37
@MelissaAutumn MelissaAutumn self-assigned this Jun 13, 2024
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MelissaAutumn MelissaAutumn merged commit e5eb6ef into main Jun 27, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the features/448-health-check-v2 branch June 27, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants