Fix uuids always producing the same result: #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass uuid as a callable not a result * Fix re-create the uuid index to make them unique * Re-generate all uuids * Add tests to test uniqueness.
devmount
approved these changes
Jun 13, 2024
| @@ -179,7 +179,7 @@ class Appointment(Base): | |||
| __tablename__ = 'appointments' | |||
|
|
|||
| id = Column(Integer, primary_key=True, index=True) | |||
| uuid = Column(UUIDType(native=False), default=uuid.uuid4(), index=True) | |||
| uuid = Column(UUIDType(native=False), default=uuid.uuid4, index=True, unique=True) | |||
There was a problem hiding this comment.
SQLAlchemy also provides a Uuid type since 2.0, I think using that could prevent issues with default values maybe.
https://docs.sqlalchemy.org/en/20/core/type_basics.html#sqlalchemy.types.Uuid
There was a problem hiding this comment.
Also thanks for adding unique=True! How could we possibly miss that 😅
There was a problem hiding this comment.
We generally don't need uniqueness because most if not everything is scoped by the subscriber. But I felt like it'd be silly not to unique a uuid.
And I can make a ticket for that in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy mistake to miss, now fixed and tested.