One curve to rule them all: Eliminate dependency to ethereum/go-ethereum #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use `btcsuite/btc/btcec` as a curve implementation in `ephemeral` and `frost` packages. This allows to eliminate the dependency to `ethereum/go-ethereum` altogether. The Marshal and Unmarshal code for points had to be copied from `ethereum/go-ethereum` to `bip340.go`. I found no code in `btcsuite/btc/btcec` doing what we need.
lukasz-zimnoch
approved these changes
Oct 15, 2024
| // byteLen := (BitCurve.BitSize + 7) >> 3 | ||
| // ret := make([]byte, 1+2*byteLen) | ||
| return 65 | ||
| byteLen := (b.BitSize + 7) >> 3 |
There was a problem hiding this comment.
Non-blocking: I would take an opportunity an explain the bitwise magic for future-us. For example, here we divide by 8 but it took me a while to figure this out 😅 Same regarding other places in-scope of this PR.
| // ret := make([]byte, 1+2*byteLen) | ||
| return 65 | ||
| byteLen := (b.BitSize + 7) >> 3 | ||
| return 1 + 2*byteLen | ||
| } | ||
|
|
||
| // SerializePoint serializes the provided elliptic curve point to bytes. | ||
| // The slice length is equal to SerializedPointLength(). | ||
| func (b *Bip340Curve) SerializePoint(p *Point) []byte { |
There was a problem hiding this comment.
Probably not in-scope of this PR but we are not checking whether the given point is on the curve here. If this is ok, it's worth flagging this in the method's docstring. This may cause unexpected errors if we ever attempt to marshal a point whose coordinates use a different byte size than the BIP340 curve so, worth flagging.
| @@ -113,6 +112,57 @@ func (b *Bip340Curve) DeserializePoint(bytes []byte) *Point { | |||
| return point | |||
| } | |||
|
|
|||
| // Marshal and Unmarshal as well as readBits were copied from | |||
There was a problem hiding this comment.
Non-blocking: Worth covering Marshal and Unmarshal with some basic unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15
We now use
btcsuite/btc/btcecas a curve implementation inephemeralandfrostpackages. This allows to eliminate the dependency toethereum/go-ethereumaltogether. The Marshal and Unmarshal code for points had to be copied fromethereum/go-ethereumtobip340.go. I found no code inbtcsuite/btc/btcecdoing what we need.