Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from hub to gh #273

Merged
merged 1 commit into from
Sep 23, 2014
Merged

Switch from hub to gh #273

merged 1 commit into from
Sep 23, 2014

Conversation

croaky
Copy link
Contributor

@croaky croaky commented Aug 10, 2014

gh is a hub reimplementation that's much faster and is now the official
Github CLI. It appears that "hub" is deprecated.

@croaky croaky mentioned this pull request Aug 10, 2014
@croaky
Copy link
Contributor Author

croaky commented Aug 10, 2014

I am guessing at the Linux implementation. @djcp @pbrisbin


url="https://github.com/jingweno/gh/releases/download/v${version}/gh_${version}_${arch}.deb"
curl $url -sLo ~/.bin/gh.deb
sudo dpkg -i ~/.bin/gh.deb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a ".deb", doesn't that mean it can be installed like a normal package, putting the executable wherever the package dictates (e.g. /usr/bin/gh)?

/cc @djcp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what you mean, @pbrisbin. I would not download the .deb package into ~/.bin/, though. I'd download the .deb to /tmp/, install, and then remove afterwards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume sudo dpkg -i foo.deb is installing the package globally, as if it had come from the repos. I also assume such an installation puts the binary in the usual place. So I'm confused why the next line (chmod +x ~/.bin/gh) is happening.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely clear on what the right approach is here. @djcp or @pbrisbin could one of you take this branch over to get the Linux version working the way you think is best?

@djcp
Copy link
Contributor

djcp commented Aug 15, 2014

I was hoping a repo would magically appear for this, but I'm happy you pushed this forward @croaky and think this is great. Let me know if you have time to clean this up, otherwise I can move it forward.

@croaky
Copy link
Contributor Author

croaky commented Aug 15, 2014

@djcp If you could push it forward, that would be great. I really meant for the Linux version to be a spike / starting point. I wasn't fully testing it on my Mac and figured it was rough / horridly written, that it would need someone else's attention before being merged.

@croaky
Copy link
Contributor Author

croaky commented Sep 1, 2014

I pushed all the style changes.

@croaky
Copy link
Contributor Author

croaky commented Sep 22, 2014

@pbrisbin Would it be possible for you to push the Linux version over the finish line?

@pbrisbin
Copy link
Contributor

Yes, sorry I meant to but forgot. Will look at it again this week.

@pbrisbin https://github.com/pbrisbin Would it be possible for you to
push the Linux version over the finish line?


Reply to this email directly or view it on GitHub
#273 (comment).

@croaky
Copy link
Contributor Author

croaky commented Sep 22, 2014

Awesome, thanks. No worries. I forgot about it, too, until I hopped in
today to work on another PR.

On Sun, Sep 21, 2014 at 5:50 PM, pat brisbin [email protected]
wrote:

Yes, sorry I meant to but forgot. Will look at it again this week.

@pbrisbin https://github.com/pbrisbin Would it be possible for you to
push the Linux version over the finish line?


Reply to this email directly or view it on GitHub
#273 (comment).


Reply to this email directly or view it on GitHub
#273 (comment).

[gh] is a [hub] reimplementation that's much faster and is now the official
Github CLI. It appears that "hub" is [deprecated].

[gh]: https://github.com/jingweno/gh
[hub]: https://github.com/github/hub
[deprecated]: mislav/hub#475
@pbrisbin pbrisbin merged commit d9a9dfe into master Sep 23, 2014
@croaky croaky deleted the dc-gh branch October 2, 2014 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants