Skip to content

Commit

Permalink
Disconnect $base-spacing from $base-line-height
Browse files Browse the repository at this point in the history
The two serve different purposes and their values don't need to be
relational. Also, since we do not facilitate or support a vertical
rhythm, the two variables do not need to be connected.

One situation where I've found this to be problematic (when they are
connected) is when I want to tweak the line height for a specific
typeface, but I don't want that change to manipulate spacing throughout
the whole application.
  • Loading branch information
tysongach committed Jun 26, 2017
1 parent cefe2c5 commit e75774a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ $heading-line-height: 1.2;

// Other Sizes
$base-border-radius: 3px;
$base-spacing: $base-line-height * 1em;
$base-spacing: 1.5em;
$small-spacing: $base-spacing / 2;
$base-z-index: 0;

Expand Down

0 comments on commit e75774a

Please sign in to comment.