This repository has been archived by the owner on Aug 14, 2022. It is now read-only.
Add support for cross-platform and Windows PDF viewers #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally, I added pdf-view to dependencies, but it looks there's no support for adding dependencies onto other Atom packages. Instead, it now detects pdf-view and will use it if available. Otherwise, there's a friendly error suggesting to install the package. |
|
This looks extremely promising. Merging locally and testing it right now. |
thomasjo
added a commit
that referenced
this pull request
Jan 28, 2015
|
Merged! Thanks for helping out — finally we a better Windows story ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add support for (and dependency on) the pdf-view module to allow previewing directly in Atom. If no other opener is found/configured, the built-in preview is used as a fallback.
I've also added basic support for opening SumatraPDF on Windows. Unfortunately Acrobat puts a write lock on PDF files, preventing the LaTeX build from succeeding while the PDF is open. Sumatra will auto-refresh the PDF view on update.