Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Add config option for SyncTeX #183

Merged
merged 2 commits into from
Jun 10, 2016
Merged

Add config option for SyncTeX #183

merged 2 commits into from
Jun 10, 2016

Conversation

alexcormier
Copy link
Contributor

I love this package but I'm not a huge fan of SyncTeX, so I added an option to let me disable it. I thought I'd submit a PR in case you're interested in merging it.

@@ -101,6 +101,12 @@
"default": false,
"order": 5
},
"enableSynctex": {
"title": "Enable SyncTeX",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "description":.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it? I added a title to display proper casing. Like this:
2016-06-05-132017_136x33_scrot
Changing it to description yields this:
2016-06-05-131858_126x47_scrot

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you are entirely correct! Was confusing myself thinking you were changing the description, but there is no description.

@thomasjo
Copy link
Owner

thomasjo commented Jun 5, 2016

Thanks for contributing! 🙇

Other than the few comment minor comments, this looks good. As soon as those comments are addressed, I'll merge 🚢 this.

@alexcormier
Copy link
Contributor Author

Should be better now. 😄

@thomasjo thomasjo merged commit 404330f into thomasjo:master Jun 10, 2016
@thomasjo
Copy link
Owner

Sorry about the delay in merging this! And thanks again for contributing 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants