Marker implementation

[Focus]

Implemented markers #165. Along the way there was an issue with the way log parser was parsing #166 which is fixed.

[thomasjo]

Thanks for the contribution! 🙇

I've started reviewing your changes, and overall it looks awesome. There are some style problems that will have to be addressed however. For some reason unknown to me right now, the CI linting is not behaving as expected and is currently producing false positives. In the meantime to uncover said style issues you can locally execute standard, e.g.

$ ./node_modules/.bin/standard lib/**/*.js

For your convenience, I dumped the errors into a gist:
https://gist.github.com/thomasjo/c7b77bb34fa0fdcd0d8f

---

Side note: I'm looking into the false positives right now.
UPDATE: I fixed the false positives during CI.

[thomasjo]

The CI process now correctly fails on the style issues mentioned earlier.

---

To make it even easier to uncover these during local development, I'll look into providing some utility functions, as well as creating a contribution guide.

[Focus]

Thanks for the feedback. I fixed the issues with formatting. Let me know if it needs any more changes.

[thomasjo]

Change this class name from line-red to latex-error.

[Focus]

Done

[thomasjo]

Done

Excellent, but we also need to address the explicit color usage as I mentioned in #167 (comment).

I can change it post-merge, but it would be great if you could refactor the style. Exactly what I want is this

@import "ui-variables";

:host(:host) .gutter .line-number {
  &.latex-error {
    background-color: fade(@background-color-error, 50%);
    color: @text-color-error;
  }
  &.latex-warning {
    background-color: fade(@background-color-warning, 50%);
    color: @text-color-warning;
  }
}

Note that I haven't tested these styles, but they follow the official Atom styleguide, so I'm reasonably confident it will look OK.

[Focus]

Sorry I completely missed that. I implemented the changes you asked for. I also found a small bug where editor.getPath() would return undefined when one of the editors is a new page and fixed this as well.

Here are some screenshots under various themes:
atom-dark:

atom-light:

one-dark:

seti:

[Focus]

I have given you access to my fork, so that you can push your own changes as well. I am more than happy to help with anything as well.

[thomasjo]

This looks really good! I can make some minor tweaks after merging if necessary.
Thanks again for this, such an awesome feature ✨

[Focus]

Excellent. Thanks for feedback