Add support for ps and dvi file formats for latexmk builder #143
Conversation
| @@ -59,6 +60,13 @@ export default class LatexmkBuilder extends Builder { | |||
| args.push(`-outdir="${outdir}"`) | |||
| } | |||
|
|
|||
| if (outputFormat) { | |||
| if (outputFormat !== 'pdf') { | |||
There was a problem hiding this comment.
These two lines should probably be combined into
if (outputFormat && outputFormat !== 'pdf') {Although since the config value is an enum, this should in reality always pass the first test, so in theory we should be able to remove the truthy check on outputFormat, hence reduce both if blocks down to
if (outputFormat !== 'pdf') {
|
Overall this is brilliant work, and thank you for helping out! I left a few line comments that I would like to address before merging though. You should at least collapse those two |
|
Thanks for your comments, and thanks for this great package. I have followed your second suggestion and just moved the initialization of const outputFormat to before the initialization of args. I have also added a default value to outputFormat in case it is not defined. (The test checking for the default command line arguments fails otherwise.) |
|
There are some minor things I'd like to tweak, but I can deal with that myself. Thanks so much for adding this @sometea. I really appreciate the help 🙇 |
Add support for ps and dvi file formats for latexmk builder
|
Thanks for merging. Let me know if something else comes up that I could possibly help with. |
Hi, I have added an option to create ps or dvi files instead of the default pdf when using the latexmk builder. Currently, this only works for latexmk, since I do not have access to texify.