Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

0.23.3 is removing the output PDF #80

Closed
nscaife opened this issue May 12, 2015 · 11 comments
Closed

0.23.3 is removing the output PDF #80

nscaife opened this issue May 12, 2015 · 11 comments
Labels

Comments

@nscaife
Copy link
Contributor

nscaife commented May 12, 2015

When building the TeX file, I briefly see the PDF appear in the Atom file list on the left, then it disappears. The log shows that the file is being created successfully. I'm getting the following errors in the console:

capture

I stepped through the package with the debugger, and it looks like the PDF is removed after the execution of this line:

fs.moveSync(originalSyncFilePath, syncFilePath);

@thedataking
Copy link
Contributor

I seem to run into the same issue.

@thomasjo thomasjo added the bug label May 12, 2015
@thomasjo
Copy link
Owner

Thanks for reporting this so quickly. Seems like an unintended side-effect of my attempt to work around the breaking change in fs-plus that lead to v0.23.3 [see https://github.com//issues/78#issuecomment-101043492].

@thomasjo
Copy link
Owner

Since the breaking change in fs-plus was introduced in v2.8.0, would one or both of you mind navigating to the latex package folder and doing something along the lines of

$ rm -r node_modules
$ apm install

I'm hoping to get a fix published in fs-plus itself, but it seems like for the time being I'll have to pin a specific version of it in this package.

@thomasjo
Copy link
Owner

@nscaife @thedataking Are either of you able to consistently reproduce this? I've been unable to reproduce with any of the versions of fs-plus from v2.5.0 up until v2.8.0 (inclusive). Since I cannot reproduce it's a little tricky to fix.

@nscaife
Copy link
Contributor Author

nscaife commented May 12, 2015

@thomasjo I can reproduce it every time.

latex

@nscaife
Copy link
Contributor Author

nscaife commented May 12, 2015

Removing the node_modules directory and doing apm install didn't fix the issue. I also totally uninstalled Atom and deleted the .atom directory and reinstalled -- same issue.

@thomasjo
Copy link
Owner

@nscaife Thanks for the update. I've managed to reproduce the problem when not using the outputDirectory option. I'm working on a fix now.

@nscaife
Copy link
Contributor Author

nscaife commented May 12, 2015

@thomasjo Thanks, as always! 😄

@thomasjo
Copy link
Owner

Just published v0.23.4 which hopefully resolves the issue. I added some new tests to guard against future regressions.

@nscaife
Copy link
Contributor Author

nscaife commented May 12, 2015

Working now, thanks again @thomasjo!

@thedataking
Copy link
Contributor

Works for me too (after restarting Atom). Thanks for fixing this so quickly @thomasjo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants