Fix problem with paths containing spaces (fixes #5 and #7)

thomasjo · May 8, 2014 · bc5cdea · bc5cdea
1 parent 490af68
commit bc5cdea
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 7 deletions.
diff --git a/lib/latexmk.coffee b/lib/latexmk.coffee
@@ -35,9 +35,9 @@ module.exports =
     if outdir?.length
       dir = path.dirname(filePath)
       outdir = path.join(dir, outdir)
-      args.push("-outdir=#{outdir}")
+      args.push("-outdir=\"#{outdir}\"")
 
-    args.push(filePath)
+    args.push("\"#{filePath}\"")
     args
 
   constructPath: ->

diff --git a/spec/fixtures/filename with spaces.tex b/spec/fixtures/filename with spaces.tex
@@ -0,0 +1,6 @@
+\documentclass{article}
+
+\begin{document}
+  \section{\LaTeX}
+  Lorem ipsum dolor sit amet...
+\end{document}
diff --git a/spec/fixtures/latexmk b/spec/fixtures/latexmk
diff --git a/spec/latex-spec.coffee b/spec/latex-spec.coffee
@@ -18,8 +18,9 @@ describe "Latex", ->
     atom.workspace = atom.workspaceView.model
 
     # Ensure package has sensible config values
-    atom.config.set("latex.texPath", "#{fixturesPath}:$PATH")
+    atom.config.set("latex.texPath", "$PATH:/usr/texbin")
     atom.config.set("latex.outputDirectory", "output")
+    atom.config.set("latex.enableShellEscape", false)
 
   describe "build", ->
     it "does nothing for new, unsaved files", ->
@@ -50,3 +51,14 @@ describe "Latex", ->
       latex.build()
 
       expect(editor.isModified()).toEqual(false)
+
+
+    it "supports paths containing spaces", ->
+      editor = atom.workspaceView.openSync("filename with spaces.tex")
+      [exitCode, done] = []
+
+      spyOn(latex, "showResult").andCallFake -> done = true
+      latex.build()
+
+      waitsFor -> done
+      runs -> expect(latex.showResult).toHaveBeenCalled();