-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.0 breaks usage with globals: true
#9
Comments
Hi, @hco thanks for your interest in I cannot reproduce that kind of behavior, I've just made the check according to what you've just said) using Can you provide me a repo to have a look at it (maybe there is a mismatch in your configuration or something) |
It works when importing the relevant files directly from the "src" folder (like in the examples), but when importing from node modules it does not work: import failOnConsole from 'vitest-fail-on-console'
// does nothing
failOnConsole() |
Just ran into this as well. v0.3.1 works as expected, v0.4.1 does not detect the console warnings. Related to #8 |
* remove nodePolyfills * update examples/ import
Hi @hco @JarvisH and @jamesdh, thanks for your insights about this issue. Have a try and tell me if everything is OK on your side! |
Bug description
I just introduced
vitest-fail-on-console
in a project, and it did not make any tests fail even though there was console output.As I checked the repo, I noticed that
0.4.0
was just released, and verified if 0.3.1 works - and yep, with 0.3.1 the tests fail.If you need a repo for reproduction, let me know, I can try to set one up :)
The text was updated successfully, but these errors were encountered: