add ignore codetype #255
Merged
add ignore codetype #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjb
requested changes
Jun 21, 2023
| @@ -153,6 +153,7 @@ def __init__(self, config, handlers, formatters={}): | |||
|
|
|||
| # Check if ignorelist is populated | |||
There was a problem hiding this comment.
Can we clean this up a little please. And change the below to:
self.ip_ignorelist = config.getVal('ip.ignorelist', default='')
self.logtype_ignorelist = config.getVal('logtype.ignorelist', default='')
There was a problem hiding this comment.
change done on both (ip and logtype)
opencanary/logger.py
Outdated
| # Log only if not in ignorelist | ||
| notify = True | ||
| if 'src_host' in logdata: | ||
| for ip in self.ignorelist: | ||
| if check_ip(logdata['src_host'], ip) == True: | ||
| notify = False | ||
| break | ||
|
|
||
| if 'logtype' in logdata: |
There was a problem hiding this comment.
if 'logtype' in logdata and logdata['logtype'] in self.logtype_ignorelist:
There was a problem hiding this comment.
change done on logtype test condition and add ip_ to ignorelist at line 172
jayjb
requested changes
Jun 23, 2023
opencanary/logger.py
Outdated
| @@ -152,7 +152,8 @@ def __init__(self, config, handlers, formatters={}): | |||
| exit(1) | |||
|
|
|||
| # Check if ignorelist is populated | |||
| self.ignorelist = config.getVal('ip.ignorelist', default='') | |||
| self.ip_ignorelist = config.getVal('ip.ignorelist', default='') | |||
There was a problem hiding this comment.
can we change to default=[] so that it is a list as we expect
jayjb
approved these changes
Jun 23, 2023
|
Hey @0x25, Thanks again for the PR. We really appreciate folks contributing and helping out. Would you mind emailing me at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows to ignore logtype (3000,4000, ...) in opencanary.conf to limit alerts.