-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-tuf logs to stdout/stderr when used as a library #376
Comments
I agree! We get logging from libraries. Repo commands can be logged directly from the cmd/. We can make sure there is no logging done in What about our deprecated code? I think it's ok to remove the logging that you are using a deprecated key, since libraries will obviously import them proactively. |
Pin go-tuf; see theupdateframework/go-tuf#376. Change-Id: Ifcb868e250214e64e8c5f032331fb839c707297e Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/722630 Fuchsia-Auto-Submit: Tamir Duberstein <[email protected]> Reviewed-by: Evan Wildenhain <[email protected]> Commit-Queue: Auto-Submit <[email protected]>
Thanks for filing this, and for the suggestion in #160 (comment)
That's a good suggestion. I think we want to:
|
I'm going to prioritize this and take this on: |
So currently I'm piping an optional logger through the client. I would like to only log the tuf ecdsa deprecated message once per client. that would maybe require a singleton in the client for that message? that feels sorta messy. anyone have any other nice go suggestions? |
@ethan-lowman-dd wdyt? |
It could be that we don't care at all for repeated lines now that we can divert the logs to a file! |
Internal operations log directly to stdout/stderr starting with #160.
It would be preferable not to interact with stdout/stderr except from within cmd/.
The text was updated successfully, but these errors were encountered: