Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v2 question regarding MountManager #1203

Closed
andrei-dascalu opened this issue Sep 25, 2020 · 5 comments
Closed

Upgrading to v2 question regarding MountManager #1203

andrei-dascalu opened this issue Sep 25, 2020 · 5 comments

Comments

@andrei-dascalu
Copy link

Question

Hello,

Seeing how the v2 beta is progressing, we are planning an upgrade process. However, I found the guidelines a bit lacking in that for example we're using the MountManager to manage 2 filesystems (Azure Blob and local). However, now the MountManager has a big deprecation warning and it will be removed.

However, the upgrade to v2 docs don't mention this bit at all. What will happen with the ability to manage multiple filesystems? I can imaging there are consistency challenges but even the thing abstraction of MM was helpful. Is there something to replace it?

Thanks

@frankdejonge
Copy link
Member

Hi @andrei-dascalu,

There have been a small number of questions regarding the MountManager (3 across various platforms). Despite that small number, I'll see what I can do. Initially, it was more about reducing the maintenance on my part (less moving parts, less maintenance). I generally like interacting with two sources separately better, but there seems to be a niche need for it.

@andrei-dascalu
Copy link
Author

Hi,

It would be great to be able to keep this bit. Otherwise the migration would be deeply painful (it's a pretty large application, which already uses an interface with an autowiring DI container). Splitting it would also beg the question as to what we can bind the implementations to (as there's a single interface we're interested in).

Thanks!

@BusterNeece
Copy link

+1 from me as a heavy user of the MountManager.

I am happy to contribute any time that is needed to help make sure MountManager is compatible with V2 as well.

@frankdejonge
Copy link
Member

I've added back the mount manager: https://github.com/thephpleague/flysystem/blob/2.x/src/MountManager.php

@eoghanobrien
Copy link

eoghanobrien commented Nov 25, 2020

Will you be removing the deprecation notice in 1.x?

* @deprecated This functionality will be removed in 2.0

jmontoyaa added a commit to jmontoyaa/flysystem that referenced this issue Dec 24, 2020
frankdejonge pushed a commit that referenced this issue Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants