length, maxLength, minLength and rangeLength validators no longer sec…

…retly trims the string. Fixes #134

README.md

@@ -880,7 +880,8 @@ Basic behaviour:
 #### Master
 
 * Fixed undefined format function when calling one of the built in validators form within a method validator. Fixes #98
-* BREAKING: Added ability to set error message per pattern. This means that if you have custom patterns, or have change the default one, you need to [add/change a default message](http://thedersen.com/projects/backbone-validation/#extending-backbone-validation/adding-custom-patterns) for it.
+* BREAKING: Added ability to set error message per pattern. This means that if you have custom patterns, or have change the default one, you need to [add/change a default message](http://thedersen.com/projects/backbone-validation/#extending-backbone-validation/adding-custom-patterns) for it. Fixes #174
+* BREAKING: length, maxLength, minLength and rangeLength validators no longer secretly trims the string. Fixes #134
 
 #### v0.8.2 [commits](https://github.com/thedersen/backbone.validation/compare/v0.8.1...v0.8.2)
 

dist/backbone-validation-amd.js

@@ -570,7 +570,7 @@
         // Validates that the value has to be a string with length equal to
         // the length value specified
         length: function(value, attr, length, model) {
-          if (!hasValue(value) || trim(value).length !== length) {
+          if (!_.isString(value) || value.length !== length) {
             return this.format(defaultMessages.length, this.formatLabel(attr, model), length);
           }
         },
@@ -579,7 +579,7 @@
         // Validates that the value has to be a string with length equal to or greater than
         // the min length value specified
         minLength: function(value, attr, minLength, model) {
-          if (!hasValue(value) || trim(value).length < minLength) {
+          if (!_.isString(value) || value.length < minLength) {
             return this.format(defaultMessages.minLength, this.formatLabel(attr, model), minLength);
           }
         },
@@ -588,7 +588,7 @@
         // Validates that the value has to be a string with length equal to or less than
         // the max length value specified
         maxLength: function(value, attr, maxLength, model) {
-          if (!hasValue(value) || trim(value).length > maxLength) {
+          if (!_.isString(value) || value.length > maxLength) {
             return this.format(defaultMessages.maxLength, this.formatLabel(attr, model), maxLength);
           }
         },
@@ -597,7 +597,7 @@
         // Validates that the value has to be a string and equal to or between
         // the two numbers specified
         rangeLength: function(value, attr, range, model) {
-          if(!hasValue(value) || trim(value).length < range[0] || trim(value).length > range[1]) {
+          if (!_.isString(value) || value.length < range[0] || value.length > range[1]) {
             return this.format(defaultMessages.rangeLength, this.formatLabel(attr, model), range[0], range[1]);
           }
         },

dist/backbone-validation.js

@@ -563,7 +563,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to
       // the length value specified
       length: function(value, attr, length, model) {
-        if (!hasValue(value) || trim(value).length !== length) {
+        if (!_.isString(value) || value.length !== length) {
           return this.format(defaultMessages.length, this.formatLabel(attr, model), length);
         }
       },
@@ -572,7 +572,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to or greater than
       // the min length value specified
       minLength: function(value, attr, minLength, model) {
-        if (!hasValue(value) || trim(value).length < minLength) {
+        if (!_.isString(value) || value.length < minLength) {
           return this.format(defaultMessages.minLength, this.formatLabel(attr, model), minLength);
         }
       },
@@ -581,7 +581,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to or less than
       // the max length value specified
       maxLength: function(value, attr, maxLength, model) {
-        if (!hasValue(value) || trim(value).length > maxLength) {
+        if (!_.isString(value) || value.length > maxLength) {
           return this.format(defaultMessages.maxLength, this.formatLabel(attr, model), maxLength);
         }
       },
@@ -590,7 +590,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string and equal to or between
       // the two numbers specified
       rangeLength: function(value, attr, range, model) {
-        if(!hasValue(value) || trim(value).length < range[0] || trim(value).length > range[1]) {
+        if (!_.isString(value) || value.length < range[0] || value.length > range[1]) {
           return this.format(defaultMessages.rangeLength, this.formatLabel(attr, model), range[0], range[1]);
         }
       },

src/backbone-validation.js

@@ -556,7 +556,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to
       // the length value specified
       length: function(value, attr, length, model) {
-        if (!hasValue(value) || trim(value).length !== length) {
+        if (!_.isString(value) || value.length !== length) {
           return this.format(defaultMessages.length, this.formatLabel(attr, model), length);
         }
       },
@@ -565,7 +565,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to or greater than
       // the min length value specified
       minLength: function(value, attr, minLength, model) {
-        if (!hasValue(value) || trim(value).length < minLength) {
+        if (!_.isString(value) || value.length < minLength) {
           return this.format(defaultMessages.minLength, this.formatLabel(attr, model), minLength);
         }
       },
@@ -574,7 +574,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string with length equal to or less than
       // the max length value specified
       maxLength: function(value, attr, maxLength, model) {
-        if (!hasValue(value) || trim(value).length > maxLength) {
+        if (!_.isString(value) || value.length > maxLength) {
           return this.format(defaultMessages.maxLength, this.formatLabel(attr, model), maxLength);
         }
       },
@@ -583,7 +583,7 @@ Backbone.Validation = (function(_){
       // Validates that the value has to be a string and equal to or between
       // the two numbers specified
       rangeLength: function(value, attr, range, model) {
-        if(!hasValue(value) || trim(value).length < range[0] || trim(value).length > range[1]) {
+        if (!_.isString(value) || value.length < range[0] || value.length > range[1]) {
           return this.format(defaultMessages.rangeLength, this.formatLabel(attr, model), range[0], range[1]);
         }
       },

tests/validators/length.js

@@ -20,7 +20,7 @@ buster.testCase("length validator", {
         });
     },
 
-    "has default error message": function(done) {
+    "has default error message for string": function(done) {
         this.model.bind('validated:invalid', function(model, error){
             assert.equals({postalCode: 'Postal code must be 2 characters'}, error);
             done();
@@ -46,6 +46,18 @@ buster.testCase("length validator", {
         }, {validate: true}));
     },
 
+    "spaces are treated as part of the string (no trimming)": function() {
+        refute(this.model.set({
+            postalCode: 'aa  '
+        }, {validate: true}));
+    },
+
+    "non strings are treated as an error": function() {
+        refute(this.model.set({
+            postalCode: 123
+        }, {validate: true}));
+    },
+
     "when required is not specified": {
         "undefined is invalid": function() {
             refute(this.model.set({

tests/validators/maxLength.js

@@ -20,7 +20,7 @@ buster.testCase("maxLength validator", {
         });
     },
 
-    "has default error message": function(done) {
+    "has default error message for string": function(done) {
         this.model.bind('validated:invalid', function(model, error){
             assert.equals({name: 'Name must be at most 2 characters'}, error);
             done();
@@ -46,6 +46,18 @@ buster.testCase("maxLength validator", {
         }, {validate: true}));
     },
 
+    "spaces are treated as part of the string (no trimming)": function() {
+        refute(this.model.set({
+            name: 'a  '
+        }, {validate: true}));
+    },
+
+    "non strings are treated as an error": function() {
+        refute(this.model.set({
+            name: 123
+        }, {validate: true}));
+    },
+
     "when required is not specified": {
         "undefined is invalid": function() {
             refute(this.model.set({

tests/validators/minLength.js

@@ -20,7 +20,7 @@ buster.testCase("minLength validator", {
         });
     },
 
-    "has default error message": function(done) {
+    "has default error message for string": function(done) {
         this.model.bind('validated:invalid', function(model, error){
             assert.equals({name: 'Name must be at least 2 characters'}, error);
             done();
@@ -46,6 +46,18 @@ buster.testCase("minLength validator", {
         }, {validate: true}));
     },
 
+    "spaces are treated as part of the string (no trimming)": function() {
+        assert(this.model.set({
+            name: 'a '
+        }, {validate: true}));
+    },
+
+    "non strings are treated as an error": function() {
+        refute(this.model.set({
+            name: 123
+        }, {validate: true}));
+    },
+
     "when required is not specified": {
         "undefined is invalid": function() {
             refute(this.model.set({

tests/validators/rangeLength.js

@@ -20,7 +20,7 @@ buster.testCase("rangeLength validator", {
         });
     },
 
-    "has default error message": function(done) {
+    "has default error message for strings": function(done) {
         this.model.bind('validated:invalid', function(model, error){
             assert.equals({name: 'Name must be between 2 and 4 characters'}, error);
             done();
@@ -58,6 +58,18 @@ buster.testCase("rangeLength validator", {
         }, {validate: true}));
     },
 
+    "spaces are treated as part of the string (no trimming)": function() {
+        refute(this.model.set({
+            name: 'aaaa '
+        }, {validate: true}));
+    },
+
+    "non strings are treated as an error": function() {
+        refute(this.model.set({
+            name: 123
+        }, {validate: true}));
+    },
+
     "when required is not specified": {
         "undefined is invalid": function() {
             refute(this.model.set({