Stores: respect replica labels in LabelValues and LabelNames #7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LabelNames and LabelValues tests fail because we dont drop replica label for LabelNames or LabelValues gRPCs |
MichaHoffmann
force-pushed
the
mhoffm-acceptance-test-for-proxy-store-with-replicas
branch
from
3a9d068 to
044e5ed
Compare
MichaHoffmann
force-pushed
the
mhoffm-acceptance-test-for-proxy-store-with-replicas
branch
from
c2c9de3 to
83ceb3e
Compare
MichaHoffmann
changed the title
MichaHoffmann
changed the title
2 tasks
Signed-off-by: Michael Hoffmann <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffm-acceptance-test-for-proxy-store-with-replicas
branch
from
83ceb3e to
a719ea3
Compare
fpetkovski
approved these changes
Apr 29, 2024
Nashluffy
pushed a commit
to Nashluffy/thanos
that referenced
this pull request
May 14, 2024
…io#7310) * Proxy: acceptance test for proxy store with replica labels Signed-off-by: Michael Hoffmann <[email protected]> * Stores: handle replica labels in label_value and label_names grpcs Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: mluffman <[email protected]>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 1, 2024
…io#7310) * Proxy: acceptance test for proxy store with replica labels Signed-off-by: Michael Hoffmann <[email protected]> * Stores: handle replica labels in label_value and label_names grpcs Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 4, 2024
…io#7310) * Proxy: acceptance test for proxy store with replica labels Signed-off-by: Michael Hoffmann <[email protected]> * Stores: handle replica labels in label_value and label_names grpcs Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added acceptance test for a proxy store with replica labels.
Verification
Acceptance Tests