Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut patch release 0.34.1 #7131

Merged

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Feb 11, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Cherry-picked 058f920 to address this CVE on 0.34 and f28680c to fix the documentation CI check.

Verification

@MichaHoffmann MichaHoffmann changed the base branch from main to release-0.34 February 11, 2024 18:33
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-cut-release-0.34.1 branch from 158da38 to bc112fb Compare February 11, 2024 18:34
hanyuting8 and others added 2 commits February 11, 2024 19:35
1、In the replace of go.mod, due to weaveworks/common#239, The grpc version is 1.45.0, but there are vulnerabilities in this version. In order to fix CVE-2023-44478, the grpc version needs to be upgraded to 1.57.2
2、In order to upgrade GRPC, the version of weaveworks/common also needs to be upgraded, otherwise the build will fail

Signed-off-by: hanyuting8 <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f28680c you can also cherry pick this to fix the docs check

The link has moved to another since Cisco bought Banzai Cloud.

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
@MichaHoffmann
Copy link
Contributor Author

f28680c you can also cherry pick this to fix the docs check

cherry picked the commit too

@fpetkovski
Copy link
Contributor

@MichaHoffmann
Copy link
Contributor Author

Should we get https://github.com/thanos-io/thanos/pull/7134in?

lets defer for 0.34.2 and/or 0.35 soon

@MichaHoffmann MichaHoffmann merged commit 4cf1559 into thanos-io:release-0.34 Feb 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants