Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web.external-prefix 404s and add web.prefix-header for bucket web UI. #1770

Merged
merged 9 commits into from
Nov 22, 2019
Merged

Fix web.external-prefix 404s and add web.prefix-header for bucket web UI. #1770

merged 9 commits into from
Nov 22, 2019

Conversation

cmanzi
Copy link
Contributor

@cmanzi cmanzi commented Nov 20, 2019 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Using the following build: quay.io/thanos/thanos:master-2019-11-20-af2a342b, I encountered 404s on static resources when trying to run the bucket web UI behind a Nginx proxy.

  • This PR fixes that by ensuring that the UI is handled at the provided external path.
  • Added web.prefix-header to provide similar functionality available in the Query UI

Verification

I am running an internal build of this branch behind a Nginx proxy with no issues.

Fixes: #1349

@cmanzi cmanzi force-pushed the http_base_path_setting branch from ad37d58 to 24b090b Compare November 20, 2019 20:02
@cmanzi
Add --web.prefix-header flag.
eab85b3 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Update changelog.
5fae9ea 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Resolve conflicts with upstream.
779bdb5 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Lint docs.
13d6c92 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
More docs linting.
56d32fd 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Remove extra flags.
245db80 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Update changelog.
515597f 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Lint docs.
7af9cd5 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi
Final docs lint.
5d568dd 
Signed-off-by: Christopher Manzi <[email protected]>
@cmanzi cmanzi force-pushed the http_base_path_setting branch from 1683efe to 5d568dd Compare November 20, 2019 20:20
bwplotka
bwplotka approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@bwplotka bwplotka merged commit 8a8f576 into thanos-io:master Nov 22, 2019
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 26, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
04552e6 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
14f5af9 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
925571a 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
96a3cf8 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
6a8fdd6 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
fa66d31 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
37dafef 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
287b8b6 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
6d686c0 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@cmanzi
Fix web.external-prefix 404s and add web.prefix-header for bucket web…
1cebcd8 
… UI. (thanos-io#1770)

* Add --web.prefix-header flag.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Resolve conflicts with upstream.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* More docs linting.

Signed-off-by: Christopher Manzi <[email protected]>

* Remove extra flags.

Signed-off-by: Christopher Manzi <[email protected]>

* Update changelog.

Signed-off-by: Christopher Manzi <[email protected]>

* Lint docs.

Signed-off-by: Christopher Manzi <[email protected]>

* Final docs lint.

Signed-off-by: Christopher Manzi <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket web view behind reverse proxy
2 participants
@cmanzi @bwplotka