Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket: Add --web.external-prefix for proxying on a subpath #1758

Merged
merged 4 commits into from
Nov 20, 2019
Merged

bucket: Add --web.external-prefix for proxying on a subpath #1758

merged 4 commits into from
Nov 20, 2019

Conversation

wrossmann
Copy link
Contributor

@wrossmann wrossmann commented Nov 19, 2019 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Added --web.external-prefix to thanos bucket web to support proxying on a subpath.
  • Updated docs with current thanos bucket web --help output.

Verification

Built clean, worked as expected locally.

@adrien-f
Copy link
Member

Hey there !

Thanks for your contribution, this looks nice. Make sure to pass the linter and we'll be good to go 😄

@wrossmann
Linter fixes
d84e632 
Signed-off-by: Wade Rossmann <[email protected]>
@wrossmann
Doc fixes
0acf9bd 
Signed-off-by: Wade Rossmann <[email protected]>
bwplotka
bwplotka approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI is still failing.

@bwplotka bwplotka merged commit c7fc04e into thanos-io:master Nov 20, 2019
@yeya24 yeya24 mentioned this pull request Nov 21, 2019
Closed
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 26, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
3e8ad04 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
ea3972d 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
35af65d 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
f92a9eb 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
bc5a64f 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
71fcd97 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
e18eb66 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
786a64b 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
453222f 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
IKSIN pushed a commit to monitoring-tools/thanos that referenced this pull request Nov 27, 2019
@wrossmann
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
ed077de 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Signed-off-by: Aleksey Sin <[email protected]>
fatsheep9146 pushed a commit to fatsheep9146/thanos that referenced this pull request Dec 4, 2019
@wrossmann @bwplotka
bucket: Add --web.external-prefix for proxying on a subpath (thanos…
fe60b69 
…-io#1758)

* bucket: Add `--web.external-prefix` for proxying on a subpath

Signed-off-by: Wade Rossmann <[email protected]>

* Update PR number from previous broken branch.

Signed-off-by: Wade Rossmann <[email protected]>

* Linter fixes

Signed-off-by: Wade Rossmann <[email protected]>

* Doc fixes

Signed-off-by: Wade Rossmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@adrien-f adrien-f adrien-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrossmann @adrien-f @bwplotka