Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.*: Only schedule on linux nodes #226

Merged
merged 1 commit into from
Jun 2, 2021
Merged

.*: Only schedule on linux nodes #226

merged 1 commit into from
Jun 2, 2021

Conversation

bip7686
Copy link
Contributor

@bip7686 bip7686 commented May 19, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Only schedule on linux nodes, due to thanos only providing linux images.

@bip7686 bip7686 force-pushed the add-nodeselector branch 4 times, most recently from 2003791 to 208f851 Compare May 19, 2021 09:06
Only schedule on linux nodes
7970604 
Signed-off-by: Luis Vidal Ernst <[email protected]>
@bip7686 bip7686 force-pushed the add-nodeselector branch from b2dec2f to 7970604 Compare May 20, 2021 10:14
@bip7686
Copy link
Contributor Author

bip7686 commented May 25, 2021

/cc @kakkoyun

kakkoyun
kakkoyun approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@metalmatze any objections?

metalmatze
metalmatze approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@metalmatze metalmatze merged commit 5d95a53 into thanos-io:main Jun 2, 2021
@bip7686 bip7686 deleted the add-nodeselector branch June 2, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bip7686 @kakkoyun @metalmatze