Add Store sharding and Receive hashrings #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
|
I don't see a need for this helpers file. The store sharding can be part of the store and similarly, the hashring can be part of the receviers. |
metalmatze
suggested changes
Nov 18, 2020
|
@metalmatze Let's reach a consensus on this PR and then I'll open separate PRs for each different group of changes. |
|
To see it on the action: observatorium/observatorium#368 |
metalmatze
suggested changes
Nov 18, 2020
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun [email protected]
Changes
helpers.libsonnetVerification
make generate