Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of some Dropshot replays #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix parsing of some Dropshot replays #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added replays/204c.replay
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions src/lib/Rattletrap/Data.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ parentClasses =
("TAGame.GRI_TA", "ProjectX.GRI_X"),
("TAGame.HauntedBallTrapTrigger_TA", "Engine.Actor"),
("TAGame.InMapScoreboard_TA", "Engine.Actor"),
("TAGame.PRI_Breakout_TA", "TAGame.PRI_TA"),
("TAGame.PRI_TA", "ProjectX.PRI_X"),
("TAGame.RBActor_TA", "ProjectX.Pawn_X"),
("TAGame.SpecialPickup_BallCarSpring_TA", "TAGame.SpecialPickup_Spring_TA"),
Expand Down Expand Up @@ -116,6 +117,7 @@ classesWithLocation =
"TAGame.GRI_TA",
"TAGame.MaxTimeWarningData_TA",
"TAGame.PickupTimer_TA",
"TAGame.PRI_Breakout_TA",
"TAGame.PRI_TA",
"TAGame.RumblePickups_TA",
"TAGame.SpecialPickup_BallCarSpring_TA",
Expand Down Expand Up @@ -244,6 +246,7 @@ objectClasses =
("TAGame.Default__CameraSettingsActor_TA", "TAGame.CameraSettingsActor_TA"),
("TAGame.Default__MaxTimeWarningData_TA", "TAGame.MaxTimeWarningData_TA"),
("TAGame.Default__PickupTimer_TA", "TAGame.PickupTimer_TA"),
("TAGame.Default__PRI_Breakout_TA", "TAGame.PRI_Breakout_TA"),
("TAGame.Default__PRI_TA", "TAGame.PRI_TA"),
("TAGame.Default__RumblePickups_TA", "TAGame.RumblePickups_TA"),
("TheWorld:PersistentLevel.BreakOutActor_Platform_TA", "TAGame.BreakOutActor_Platform_TA"),
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Rattletrap/Type/ClassAttributeMap.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ classHasRotation className =
getAttributeIdLimit :: Map.Map U32.U32 U32.U32 -> Maybe Word
getAttributeIdLimit attributeMap = do
((streamId, _), _) <- Map.maxViewWithKey attributeMap
pure (fromIntegral (U32.toWord32 streamId))
pure (fromIntegral (1 + U32.toWord32 streamId))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to know why this is required.


getAttributeName ::
ClassAttributeMap ->
Expand Down
1 change: 1 addition & 0 deletions src/test/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ replays =
("1ec9", "a V1.63 match"), -- https://github.com/tfausak/rattletrap/pull/132
("1ef9", "a private hoops match"), -- https://github.com/tfausak/rattletrap/commit/5570839
("1f37", "splitscreen players"), -- https://github.com/tfausak/rattletrap/commit/c4d2f32
("204c", "dropshot again"), -- https://github.com/tfausak/rattletrap/issues/314
("2066", "replicated boost"), -- https://github.com/tfausak/rattletrap/issues/296
("2114", "a match save"), -- https://github.com/tfausak/rattletrap/commit/ee7afa0
("21a8", "v1.66"), -- https://github.com/tfausak/rattletrap/pull/142
Expand Down
Loading