Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(t8s-cluster/management-cluster): add missing necessary image field #1247

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(t8s-cluster/management-cluster): add missing necessary image field #1247

merged 1 commit into from
Nov 28, 2024

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Nov 20, 2024

No description provided.

@cwrau cwrau enabled auto-merge (squash) November 20, 2024 13:52
@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from 72c753d to 20b3bee Compare November 20, 2024 13:59
@cwrau cwrau disabled auto-merge November 20, 2024 14:10
@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from 20b3bee to 5111a6f Compare November 20, 2024 14:11
@teutonet-bot
Copy link
Contributor

teutonet-bot commented Nov 20, 2024 •
edited
Loading

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/t8s-cluster/ci/artifacthub-values.yaml

charts/t8s-cluster/ci/cidrs-values.yaml

charts/t8s-cluster/ci/injectedCertificateAuthorities-values.yaml

charts/t8s-cluster/ci/hcp-values.yaml

charts/t8s-cluster/ci/securityGroups-values.yaml

charts/t8s-cluster/ci/calico-values.yaml

charts/t8s-cluster/ci/bastion-values.yaml

charts/t8s-cluster/values.yaml

charts/t8s-cluster/ci/gpu-flavor-values.yaml

marvinWolff
marvinWolff previously approved these changes Nov 20, 2024
View reviewed changes
@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from 5111a6f to a31d987 Compare November 20, 2024 14:25
@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from a31d987 to 8d961ca Compare November 26, 2024 08:43
@cwrau cwrau enabled auto-merge (squash) November 26, 2024 08:43
@marvinWolff
Copy link
Collaborator

Its approved, but needs rebase and auto-merge was activated after my approve

@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from 8d961ca to 9eb150a Compare November 28, 2024 09:04
@cwrau cwrau force-pushed the fix/t8s-cluster/add-necessary-image-field branch from 9eb150a to 421cbbf Compare November 28, 2024 10:20
@cwrau cwrau merged commit e3910ca into main Nov 28, 2024
17 checks passed
@cwrau cwrau deleted the fix/t8s-cluster/add-necessary-image-field branch November 28, 2024 10:43
@teutonet-bot teutonet-bot mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinWolff marvinWolff marvinWolff approved these changes

@tasches tasches Awaiting requested review from tasches tasches is a code owner

@teutonet-bot teutonet-bot Awaiting requested review from teutonet-bot teutonet-bot is a code owner

Assignees

@cwrau cwrau

Labels
t8s-cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwrau @teutonet-bot @marvinWolff