Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/sysfs: add missing tinygo tags #2337

Closed
wants to merge 2 commits into from
Closed

internal/sysfs: add missing tinygo tags #2337

wants to merge 2 commits into from

Conversation

ydnar
Copy link

@ydnar ydnar commented Nov 11, 2024

This enables running wazero under tinygo -target=wasip1 (wasm in wasm). To test:

tinygo run -target=wasip1 examples/basic/add.go 7 9

@ydnar
internal/sysfs: add missing tinygo tags
43fad9d 
This enables running wazero under tinygo -target=wasip1 (wasm in wasm). To test:

tinygo run -target=wasip1 examples/basic/add.go 7 9
@ydnar ydnar requested a review from mathetake as a code owner November 11, 2024 17:48
@mathetake
Copy link
Member

  1. This needs a CI job that has been removed in ci: Updates TinyGo to 0.33 #2304 to ensure this works as intended on our side (maybe not only just build but also we might need to run make test with TinyGo? idk)
  2. TinyGo MUST add wazero as its testing corpass so that TinyGo won't break our CI

@ydnar
.github/workflows: re-enable TinyGo in CI
a4061ec 
This may not work, due to potentially missing APIs in TinyGo.

Partially reverts tetratelabs#2304
@mathetake mathetake closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake Awaiting requested review from mathetake mathetake is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydnar @mathetake