ci: do not upload artifacts for pre-releases #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edoardo Vacchi <[email protected]>
mathetake
approved these changes
Mar 9, 2024
evacchi
added a commit
to evacchi/wazero
that referenced
this pull request
Mar 12, 2024
Partially reverts the change in tetratelabs#2143 because the alternative command uploads the artifacts anyway. The rest of tetratelabs#2143 fixes the version number for MSI artifacts, which is still required. Signed-off-by: Edoardo Vacchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSI version tags for pre-releases (candle.exe won't accept version numbers with alphabetic chars in it), but also skip publishing artifacts for pre-releases.