Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke old singlepass compiler, enable optimizing compiler by default #2130

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Mar 7, 2024

Towards 2.0 release, this deletes the entire codebase of the old single pass
compiler. As a result, the new optimizing compiler, the code name "wazevo"
will be promoted to the default engine of wazero with this commit. The detailed
explanation will be provided with the release note, but in the meantime, you can
enjoy the compiler just by upgrading your wazero to the main branch without
changing your code base at all.

It has been a crazy 9 months since I started writing the optimizing compiler from scratch,
but I feel really grateful for what we have achieved for the future!

@mathetake
Copy link
Member Author

mathetake commented Mar 7, 2024

Release workflow failures is not relevant to this PR, and will be fixed by @evacchi in a different PR

@mathetake mathetake changed the title Nukes the old single pass compiler Nukes the old single pass compiler / Enable optimizing compiler by default Mar 7, 2024
@mathetake mathetake changed the title Nukes the old single pass compiler / Enable optimizing compiler by default Nuke the old single pass compile, enable optimizing compiler by default Mar 7, 2024
@mathetake mathetake changed the title Nuke the old single pass compile, enable optimizing compiler by default Nuke old singlepass compiler, enable optimizing compiler by default Mar 7, 2024
@mathetake mathetake marked this pull request as ready for review March 7, 2024 06:19
@mathetake mathetake requested a review from evacchi as a code owner March 7, 2024 06:19
Copy link
Collaborator

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic work 👏

Copy link
Contributor

@evacchi evacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣 💥 🔥

@mathetake
Copy link
Member Author

Thank you all!

@mathetake mathetake merged commit 3c7bc73 into main Mar 7, 2024
65 checks passed
@mathetake mathetake deleted the nukeoldcompiler branch March 7, 2024 06:26
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emeritus bro-approve 👍

@ncruces
Copy link
Collaborator

ncruces commented Mar 7, 2024

My branch is now reduced to updating wazero. All tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants