api: reverts the uint32->uint64 breaking change for 2.0 release #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a61b01.
This reverts commit 1458ccc. Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
changed the title
|
cc @ncruces |
mathetake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the only/first ever breaking change we committed
towards 2.0 release, #2085 and #2074.
These commits were made to fix a bug in our API which is described well in
#1852 but the reality is that it will
cause users to modify their existing code when they upgrade to 2.0 whose main
focus is to introduce the optimizing compiler just by updating wazero, not to fix
the bug.
Note that this doesn't mean that we won't make any breaking change never, but this
is more about dedicating 2.0 to the optimizing compiler, not fixing the bug which
is highly likely that existing users will never encounter.