Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set floor Go version at 1.20 #2025

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Set floor Go version at 1.20 #2025

merged 4 commits into from
Feb 9, 2024

Conversation

mathetake
Copy link
Member

No description provided.

@mathetake
Copy link
Member Author

damn, tinygo isn't ready

@mathetake
Copy link
Member Author

so os package test of wasip1 failing

--- FAIL: BenchmarkWasip1/baseline/Run/src_os.test
    require.go:331: expected no error, but was module closed with exit_code(1): stdout: 
        stderr: 
        /home/runner/work/wazero/wazero/internal/integration_test/stdlibs/bench_test.go:222
        /home/runner/work/wazero/wazero/internal/integration_test/stdlibs/bench_test.go:175
        /opt/hostedtoolcache/go/1.22.0/x64/src/testing/benchmark.go:193
        /opt/hostedtoolcache/go/1.22.0/x64/src/testing/benchmark.go:215
        /opt/hostedtoolcache/go/1.22.0/x64/src/runtime/asm_amd64.s:16[95](https://github.com/tetratelabs/wazero/actions/runs/7823604950/job/21344829039?pr=2025#step:6:96)

@mathetake
Set floor Go version at 1.20
99fe69f 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
example flow
5c7a68e 
Signed-off-by: Takeshi Yoneda <[email protected]>
@evacchi
mount "tmp" instead of "/tmp"
6647c98 
Signed-off-by: Edoardo Vacchi <[email protected]>
@evacchi
Copy link
Contributor

evacchi commented Feb 8, 2024 •
edited
Loading

windows is still broken though (probably same root cause, issues with %TMP% on CI)

@evacchi
fix wasip1 on Windows GHA
5b869c2 
Signed-off-by: Edoardo Vacchi <[email protected]>
@evacchi
Copy link
Contributor

evacchi commented Feb 9, 2024 •
edited
Loading

yay! it really was an issue with /tmp on Windows; best fix: fixing the CI!
(as per comment: this won't happen locally, but it's necessary on GHA)

@mathetake mathetake marked this pull request as ready for review February 9, 2024 21:29
@mathetake mathetake requested a review from evacchi as a code owner February 9, 2024 21:29
@mathetake
Copy link
Member Author

💯

@mathetake mathetake merged commit abf0ada into main Feb 9, 2024
67 checks passed
@mathetake mathetake deleted the floooooooo branch February 9, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evacchi evacchi Awaiting requested review from evacchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @evacchi