fix(prefer-find-by): avoid reporting querySelector (#538)

* fix(prefer-find-by): fix report with querySelector Fix #501 * fixup! fix(prefer-find-by): fix report with querySelector
testing-library · Jan 21, 2022 · 369e24f · 369e24f
1 parent a6d4cda
commit 369e24f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/rules/prefer-find-by.ts b/lib/rules/prefer-find-by.ts
@@ -373,6 +373,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
           const callArguments = getQueryArguments(argument.body);
           const queryMethod = fullQueryMethod.split('By')[1];
 
+          if (!queryMethod) {
+            return;
+          }
+
           reportInvalidUsage(node, {
             queryMethod,
             queryVariant,

diff --git a/tests/lib/rules/prefer-find-by.test.ts b/tests/lib/rules/prefer-find-by.test.ts
@@ -149,6 +149,23 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
     },
+    {
+      code: `
+        import {screen, waitFor} from '@testing-library/foo';
+        it('tests', async () => {
+          await waitFor(() => expect(screen.querySelector('baz')).toBeInTheDocument());
+        })
+      `,
+    },
+    {
+      code: `
+        import {waitFor} from '@testing-library/foo';
+        it('tests', async () => {
+          const { container } = render()
+          await waitFor(() => expect(container.querySelector('baz')).toBeInTheDocument());
+        })
+      `,
+    },
   ],
   invalid: [
     ...createScenario((waitMethod: string, queryMethod: string) => ({