-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin kcd-scripts at 6.5 #88
Conversation
@MichaelDeBoey could use your help if you have any time. for some reason the latest version of kcd-scripts is causing errors on ajv. only thing i've found to fix this is to pin kcd-scripts@5. |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 184 184
Branches 21 21
=========================================
Hits 184 184 Continue to review full report at Codecov.
|
🎉 This PR is included in version 3.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@benmonro Do you have something more detailed that I can have a look at? |
Yeah just bump kcd scripts to latest and run yarn test |
@kentcdodds I tried to fix the problem mentioned above (see #89 & #91), but can't figure out the cause. |
Based on those I have no idea what this could be. Doesn't look related to kcd-scripts 🤷♂️ |
Seems like it has something to do with dependencies of |
Is rollup/plugins#640 going to fix this one too? 🤔 |
Potentially. I haven't looked into the issues here. But if it is that issue, you can work around it by adding |
Nope, seems like adding |
What:
Why:
How:
Checklist: