Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin kcd-scripts at 6.5 #88

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix: pin kcd-scripts at 6.5 #88

merged 1 commit into from
Oct 24, 2020

Conversation

benmonro
Copy link
Member

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@benmonro
Copy link
Member Author

@MichaelDeBoey could use your help if you have any time. for some reason the latest version of kcd-scripts is causing errors on ajv. only thing i've found to fix this is to pin kcd-scripts@5.

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          184       184           
  Branches        21        21           
=========================================
  Hits           184       184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167137a...4d3558f. Read the comment docs.

@benmonro benmonro changed the title fix: pin [email protected] fix: pin kcd-scripts at 6.5 Oct 24, 2020
@benmonro benmonro merged commit c10ece9 into master Oct 24, 2020
@benmonro benmonro deleted the feature/pin-kcd-scripts branch October 24, 2020 16:40
@benmonro
Copy link
Member Author

🎉 This PR is included in version 3.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Oct 25, 2020

@benmonro Do you have something more detailed that I can have a look at?

@benmonro
Copy link
Member Author

Yeah just bump kcd scripts to latest and run yarn test

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Nov 12, 2020

@kentcdodds I tried to fix the problem mentioned above (see #89 & #91), but can't figure out the cause.
Problem is also appearing with latest kcd-scripts (see #93 & #94)

@kentcdodds
Copy link
Member

Based on those I have no idea what this could be. Doesn't look related to kcd-scripts 🤷‍♂️

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Nov 13, 2020

Seems like it has something to do with dependencies of kcd-scripts as 6.5 is working, but newer isn't working anymore 🤔😕

@MichaelDeBoey
Copy link
Member

Is rollup/plugins#640 going to fix this one too? 🤔

@kentcdodds
Copy link
Member

Potentially. I haven't looked into the issues here. But if it is that issue, you can work around it by adding @types/estree to your devDependencies.

@MichaelDeBoey
Copy link
Member

Nope, seems like adding @types/estree isn't fixing the TypeError: Ajv is not a constructor error 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants