Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(to-have-text-content): improved handling non literals and regex in autofix #65

Merged
merged 2 commits into from
Jul 12, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Jul 11, 2020

What: improve autofixing in prefer-to-have-text-content

Why: fixes #53 fixes #52

How: more use of getText()

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          136       138    +2     
  Branches        21        21           
=========================================
+ Hits           136       138    +2     
Impacted Files Coverage Δ
src/rules/prefer-to-have-text-content.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808c623...4c257a8. Read the comment docs.

@benmonro benmonro changed the title fix(to-have-text-content): handle non literals in autofix fix(to-have-text-content): improved handling non literals and regex in autofix Jul 12, 2020
@benmonro benmonro merged commit f5a983d into master Jul 12, 2020
@benmonro benmonro deleted the bug/text-content-autofix-regex branch July 12, 2020 00:43
@benmonro
Copy link
Member Author

🎉 This PR is included in version 3.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant