Rule jest-dom/prefer-to-have-attribute autofix breaks the code

[RIP21]

• eslint-plugin-jest-dom version: 3.0.1
• node version: 12.16.1
• npm version: 6.13.4

Turns this

 expect(link.getAttribute('href')).toContain(`fincrime_analyst=${encodeURIComponent(mockedAnalyst.id)}`)

Into this

expect(link).toHaveAttribute('href', expect.stringContaining(undefined))

[benmonro]

Yikes thanks for reporting. Mind opening a pull request?

[RIP21]

@benmonro I wish I have free time for that and familiarity with the codebase and ESLint instruments for AST stuff :) (I'm familiar with Babel mostly)
Anyway, will see, maybe I'll have motivation to do that :)

Any resources you recommend to check out to get up to speed quickly?

[benmonro]

@RIP21 i personally like www.astexplorer.net as a playground. In fact I do most of my work in that then move it into vscode from there. Other than that the eslint docs are pretty good too.

[RIP21]

@benmonro sure, it's impossible to work with AST without it (the explorer) :D
Okay, nothing new then. Babel documentation is a little meh and you really need to be stubborn to finally find something good about their AST instruments not just about plugins etc. that's why I'm asking :)

[benmonro]

Yeah. What I like about eslint is the query syntax. It's very similar to a css selector but for Dom nodes instead. Anyway if I have time I'll comment on the issue that I'm working on it but it might be a few days as I'm on a family vacation at the moment

[benmonro]

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[benmonro]

🎉 This issue has been resolved in version 3.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀