-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add accessibility-alt-text-bot #1240
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f569972:
|
Codecov Report
@@ Coverage Diff @@
## main #1240 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 346 346
=========================================
Hits 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea.
But the build seems to be having some troubles with it 👀
Oh, I think it's failing because I'm not synced with master and we pinned browserlist, I'll fix that :) Thanks! |
@MatanBobi Thanks! Feel free to merge this if you want, as this clearly isn't the cause of the CI failure, and merging should fix it anyway. |
Ok, the reason it's failing is because we're testing on Node 14 and have an |
I think we can just merge this then, I'm not aware of any issues that aren't already on |
* feat: upgrade aria-query to 5.3.0 * fix: correctly handle img with empty alt * feat: pin `aria-query` version * chore: add accessibility-alt-text-bot (#1240) * chore: add accessibility-alt-text-bot * fix formatting issues * test: add coverage for footer to confirm it's expected implicit role as contentinfo --------- Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Matan Borenkraout <[email protected]>
* feat: upgrade aria-query to 5.3.0 * fix: correctly handle img with empty alt * feat: pin `aria-query` version * chore: add accessibility-alt-text-bot (testing-library#1240) * chore: add accessibility-alt-text-bot * fix formatting issues * test: add coverage for footer to confirm it's expected implicit role as contentinfo --------- Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Matan Borenkraout <[email protected]>
What: Adds a workflow to add the accessibility alt text bot.
Following this guide.
Why: To enforce adding alt text to images in issues and PR's.
Checklist:
Documentation added to thedocs site
TestsTypeScript definitions updated