Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add accessibility-alt-text-bot #1240

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

MatanBobi
Copy link
Member

What: Adds a workflow to add the accessibility alt text bot.
Following this guide.

Why: To enforce adding alt text to images in issues and PR's.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f569972:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1240 (f569972) into main (069e184) will not change coverage.
The diff coverage is n/a.

❗ Current head f569972 differs from pull request most recent head 2c04510. Consider uploading reports for the commit 2c04510 to get more accurate results

@@            Coverage Diff            @@
##              main     #1240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       346       346           
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MatanBobi MatanBobi requested a review from nickserv June 15, 2023 11:58
@MatanBobi MatanBobi requested a review from timdeschryver July 17, 2023 11:38
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea.
But the build seems to be having some troubles with it 👀

@MatanBobi
Copy link
Member Author

I like the idea. But the build seems to be having some troubles with it 👀

Oh, I think it's failing because I'm not synced with master and we pinned browserlist, I'll fix that :) Thanks!

@nickserv
Copy link
Member

@MatanBobi Thanks! Feel free to merge this if you want, as this clearly isn't the cause of the CI failure, and merging should fix it anyway.

@MatanBobi
Copy link
Member Author

MatanBobi commented Jul 20, 2023

Ok, the reason it's failing is because we're testing on Node 14 and have an overrides solution for browserlist which doesn't work in npm 6. That's a problem because our tests will always fail for node 14 with this solution.
I've written that in the issue we have.

@nickserv
Copy link
Member

I think we can just merge this then, I'm not aware of any issues that aren't already on main.

@MatanBobi MatanBobi merged commit 336152b into main Sep 10, 2023
@nickserv nickserv deleted the chores/add-accessibility-alt-text-bot branch September 10, 2023 09:17
nickserv added a commit that referenced this pull request Sep 10, 2023
MatanBobi added a commit that referenced this pull request Sep 14, 2023
* feat: upgrade aria-query to 5.3.0

* fix: correctly handle img with empty alt

* feat: pin `aria-query` version

* chore: add accessibility-alt-text-bot (#1240)

* chore: add accessibility-alt-text-bot

* fix formatting issues

* test: add coverage for footer to confirm it's expected implicit role as contentinfo

---------

Co-authored-by: Sebastian Silbermann <[email protected]>
Co-authored-by: Matan Borenkraout <[email protected]>
eps1lon added a commit to eps1lon/dom-testing-library that referenced this pull request Oct 3, 2023
* feat: upgrade aria-query to 5.3.0

* fix: correctly handle img with empty alt

* feat: pin `aria-query` version

* chore: add accessibility-alt-text-bot (testing-library#1240)

* chore: add accessibility-alt-text-bot

* fix formatting issues

* test: add coverage for footer to confirm it's expected implicit role as contentinfo

---------

Co-authored-by: Sebastian Silbermann <[email protected]>
Co-authored-by: Matan Borenkraout <[email protected]>
@eps1lon eps1lon mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants