-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use ARIA 1.2 for role queries #1058
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 894b685:
|
Codecov Report
@@ Coverage Diff @@
## main #1058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 928 952 +24
Branches 287 311 +24
=========================================
+ Hits 928 952 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think that's viable. We want to follow the stable release more closely anyway so querying behavior may change more frequently. Let's see if people prefer stable behavior in their tests over stable spec behavior. |
@all-contributors add @IanVS for code |
I've put up a pull request to add @IanVS! 🎉 |
🎉 This PR is included in version 8.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for merging this @eps1lon. Note that there's also a PR open for jest-dom as well: testing-library/jest-dom#414. |
Co-authored-by: eps1lon <[email protected]>
What:
Updates aria-query to version 5.0.0.
Closes #703
Closes #997
Why:
I hit an issue with vite/rollup stumbling on babel/corejs which was being brought in via aria-query. The latest version of aria-query removes these dependencies, opting to use objects and arrays instead of Maps and Sets. But they did so in a mostly backwards-compatible way, and did not break the usage of the package here in dom-testing-library.
Ref: #995 (but I don't think this PR quite closes it)
In my own app, this change resolves the problems I was having.
How:
Updated and ran tests.
Checklist:
docs site N/A
Corresponding jest-dom PR: testing-library/jest-dom#414
I couldn't update the type definitions because there is not a new definitely typed version. I opened a discussion for it. DefinitelyTyped/DefinitelyTyped#56549 (comment)