Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numerical characters in example names/titles #922

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Mar 7, 2023

What does this PR do?

This PR relaxes the requirement around example names and titles.
Names and titles cannot currently include any numbers, which is too limiting.

Why is it important?

This is important for products where numbers are included... like Neo4j :)

Related issues

This is a prerequisite for the Neo4j work initially discussed in #636, and isolated in #921.

How to test this PR

cd modulegen
go run . --name neo4j --image "docker.io/neo4j:5.5" --title Neo4j

This should now work.

@fbiville fbiville requested a review from a team as a code owner March 7, 2023 17:34
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7ddad3e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64077e13bb599200087c44e9
😎 Deploy Preview https://deploy-preview-922--testcontainers-go.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdelapenya
mdelapenya previously approved these changes Mar 7, 2023
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this improvement, now it's possible to create the neo4j module

👏👏👏

@mdelapenya
Copy link
Member

@fbiville btw, could you update the docs with the alphanumerical change? It lives under docs/modules/index.md 🙏

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdelapenya mdelapenya merged commit 2ec7297 into testcontainers:main Mar 7, 2023
@mdelapenya
Copy link
Member

Thanks @fbiville for your time making the module generation smarter! Much appreciated!

@mdelapenya mdelapenya added the enhancement New feature or request label Mar 7, 2023
@mdelapenya mdelapenya self-assigned this Mar 7, 2023
@fbiville fbiville deleted the allow_alphanum branch March 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants