-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow numerical characters in example names/titles #922
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this improvement, now it's possible to create the neo4j module
👏👏👏
@fbiville btw, could you update the docs with the |
Kudos, SonarCloud Quality Gate passed! |
Thanks @fbiville for your time making the module generation smarter! Much appreciated! |
What does this PR do?
This PR relaxes the requirement around example names and titles.
Names and titles cannot currently include any numbers, which is too limiting.
Why is it important?
This is important for products where numbers are included... like Neo4j :)
Related issues
This is a prerequisite for the Neo4j work initially discussed in #636, and isolated in #921.
How to test this PR
This should now work.