Fix rotation on Android, using EXIF data #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be the cause to the issue I was seeing here: #149 (comment) Thank you for this 👍 |
maheshwaripurvesh
added a commit
to maheshwaripurvesh/react-native-sketch-canvas
that referenced
this pull request
Sep 19, 2022
Some Android phones have their camera sensors mounted sideways, upside down, ect. The BitmapFactory#decodeFile method does not take this into account, by default. So, when the file is decoded, it could end up getting shown in an incorrect orientation on the canvas. iOS manages this correctly already. This PR just fixes the issue for Android devices. Please refer original commit to root repo terrylinla#135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Android phones have their camera sensors mounted sideways, upside down, ect. The
BitmapFactory#decodeFilemethod does not take this into account, by default. So, when the file is decoded, it could end up getting shown in an incorrect orientation on the canvas.iOS manages this correctly already. This PR just fixes the issue for Android devices.