feat: add confidential computing example #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
@apeabody @erlanderlo could you please take a look? |
|
/gcbrun |
erlanderlo
reviewed
Aug 28, 2024
test/integration/confidential_compute_instance/confidential_compute_instance_test.go
Outdated
Show resolved
Hide resolved
|
@apeabody could you please rerun the checks? I'm not sure why lint failed though (it's succeeding locally in my machine), would you have a clue? Thanks! |
apeabody
reviewed
Aug 28, 2024
|
/gcbrun |
Co-authored-by: Andrew Peabody <[email protected]>
|
/gcbrun |
erlanderlo
reviewed
Sep 4, 2024
test/integration/confidential_compute_instance/confidential_compute_instance_test.go
Show resolved
Hide resolved
|
@apeabody could you run /gcbrun again, please? |
|
/gcbrun |
erlanderlo
approved these changes
Sep 8, 2024
apeabody
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add confidential computing example with custom SA and Cloud HSM encrypted disk.