fix(variables)!: allow optional attributes for update_policy object #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
requested changes
May 23, 2024
There was a problem hiding this comment.
Thanks @eeaton!
optional was added as experimental in terraform v0.14 and GA in v1.3. Can you please bump https://github.com/terraform-google-modules/terraform-google-vm/blob/master/autogen/versions.tf.tmpl#L18
Also we should prefix this PR as fix to trigger release-please and include in the release notes.
eeaton
changed the title
|
/gcbrun |
|
Thanks for the feedback, I've made the requested changes. |
|
/gcbrun |
apeabody
changed the title
|
mark as |
apeabody
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to address #406 . Several attributes that are optional in the Google provider are treated as required in this module which introduces errors.
I think this will also address #405