feat: Update instance template var.additional_disks to include all fields being passed to API #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
changed the title
bharathkkb
approved these changes
Apr 19, 2024
|
not marking as breaking as this already needed 1.3 due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #391 as I ran into a similar issue. This PR improves upon #392 by supporting all fields being set in the
local.all_disksobject. I have chosen to default tonullfor nearly every field to maintain backwards compatibility. I have added a couple exceptions where I think we can reasonably express an opinion, although I think a review/discussion is warranted.Underlying issue: I read the
main.tfcode, and suppliedsourceas a parameter to additional_disks and spent a couple hours debugging until I realized that Terraform was silently ingoring the extra field.