feat: expose distribution_policy_target_shape setting for MIGs #327
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpdownes
force-pushed
the
feat_distribution_policy_shape
branch
from
b4f2251 to
89ba23e
Compare
tpdownes
force-pushed
the
feat_distribution_policy_shape
branch
from
89ba23e to
c41608e
Compare
tpdownes
changed the title
bharathkkb
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows specification of the distribution_policy_target_shape settings for MIGs. Although this setting is optional, it has a significant impact on the user experience. For example, using the "BALANCED" setting instead of "EVEN" (default) enables the user to use regional MIGs even when a particular VM type is not available in all zones. This is common for new VM families with limited hardware availability (e.g. G2 GPU family).
https://cloud.google.com/compute/docs/instance-groups/regional-mig-distribution-shape#comparison_of_shapes
I have made the choice to set the default value to
nullto most closely simulate the status quo. I could add validation, but have chosen not to incase there are new future values. We could discuss modifying either decision.