Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spot instances #294

Merged

Conversation

llinros
Copy link
Contributor

@llinros llinros commented Feb 6, 2023

Adds option to use spot instances
fixes #259

@llinros llinros requested a review from a team as a code owner February 6, 2023 08:46
@google-cla
Copy link

google-cla bot commented Feb 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@comment-bot-dev
Copy link

@llinros
Thanks for the PR! 🚀
✅ Lint checks have passed.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 30, 2023
@github-actions github-actions bot closed this Jun 7, 2023
@fabianrenner
Copy link

When is this expected to be merged?

@abatilo
Copy link

abatilo commented Jun 13, 2023

@apeabody or @g-awmalik maybe? Could we get someone to take a look at these changes and re-open this PR?

@apeabody apeabody removed the Stale label Jun 13, 2023
@apeabody apeabody reopened this Jun 13, 2023
@apeabody
Copy link
Contributor

/gcbrun

@karolcienkosz
Copy link

Hi, is there any chance for review?

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @llinros! - This looks good from a code review stand point. Ideally we should have an test exercise spot=true.

@bharathkkb
Copy link
Member

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 99efc45 into terraform-google-modules:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for spot instances
8 participants