Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spot instances #259

Closed
jawnsy opened this issue Aug 30, 2022 · 8 comments · Fixed by #294
Closed

Add support for spot instances #259

jawnsy opened this issue Aug 30, 2022 · 8 comments · Fixed by #294
Labels
enhancement New feature or request Stale

Comments

@jawnsy
Copy link

jawnsy commented Aug 30, 2022

TL;DR

This module supports preemptible instances, but not spot instances

Terraform Resources

We should be able to use provisioning_model = SPOT to support spot instances: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_template#nested_scheduling

Detailed design

Add a "spot" variable in the model and set the provisioning_model here:

# scheduling must have automatic_restart be false when preemptible is true.
scheduling {
preemptible = var.preemptible
automatic_restart = !var.preemptible
on_host_maintenance = local.on_host_maintenance
}

Additional information

No response

@jawnsy jawnsy added the enhancement New feature or request label Aug 30, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 29, 2022
@jawnsy
Copy link
Author

jawnsy commented Oct 31, 2022

I believe this is still a valid issue

@github-actions github-actions bot removed the Stale label Oct 31, 2022
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 31, 2022
@jawnsy
Copy link
Author

jawnsy commented Jan 1, 2023

This is still a valid issue

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 3, 2023
@jawnsy
Copy link
Author

jawnsy commented Mar 6, 2023

I think this is still an issue until #294 is merged

@apeabody apeabody removed the Stale label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
@jawnsy
Copy link
Author

jawnsy commented May 14, 2023

This is still a valid issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants