Update variable type for autoscaling_cpu

terraform-google-modules · Oct 17, 2022 · 66e45b4 · 66e45b4
1 parent 64b0d14
commit 66e45b4
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 8 deletions.
diff --git a/autogen/variables.tf.tmpl b/autogen/variables.tf.tmpl
@@ -184,7 +184,10 @@ variable "autoscaling_mode" {
 
 variable "autoscaling_cpu" {
   description = "Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization"
-  type        = list(map(number))
+  type        = list(object({
+    target            = number
+    predictive_method = string
+  }))
   default     = []
 }
 

diff --git a/examples/mig/healthcheck/main.tf b/examples/mig/healthcheck/main.tf
@@ -71,7 +71,8 @@ module "mig" {
 
   autoscaling_cpu = [
     {
-      target = 0.4
+      target            = 0.4
+      predictive_method = null # use default of NONE
     },
   ]
 

diff --git a/modules/mig/README.md b/modules/mig/README.md
@@ -19,7 +19,7 @@ The current version is 2.X. The following guides are available to assist with up
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | autoscaler\_name | Autoscaler name. When variable is empty, name will be derived from var.hostname. | `string` | `""` | no |
-| autoscaling\_cpu | Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization | `list(map(number))` | `[]` | no |
+| autoscaling\_cpu | Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization | <pre>list(object({<br>    target            = number<br>    predictive_method = string<br>  }))</pre> | `[]` | no |
 | autoscaling\_enabled | Creates an autoscaler for the managed instance group | `string` | `"false"` | no |
 | autoscaling\_lb | Autoscaling, load balancing utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#load_balancing_utilization | `list(map(number))` | `[]` | no |
 | autoscaling\_metric | Autoscaling, metric policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#metric | <pre>list(object({<br>    name   = string<br>    target = number<br>    type   = string<br>  }))</pre> | `[]` | no |

diff --git a/modules/mig/variables.tf b/modules/mig/variables.tf
@@ -169,8 +169,11 @@ variable "autoscaling_mode" {
 
 variable "autoscaling_cpu" {
   description = "Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization"
-  type        = list(map(number))
-  default     = []
+  type = list(object({
+    target            = number
+    predictive_method = string
+  }))
+  default = []
 }
 
 variable "autoscaling_metric" {

diff --git a/modules/mig_with_percent/README.md b/modules/mig_with_percent/README.md
@@ -18,7 +18,7 @@ The current version is 2.X. The following guides are available to assist with up
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | autoscaler\_name | Autoscaler name. When variable is empty, name will be derived from var.hostname. | `string` | `""` | no |
-| autoscaling\_cpu | Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization | `list(map(number))` | `[]` | no |
+| autoscaling\_cpu | Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization | <pre>list(object({<br>    target            = number<br>    predictive_method = string<br>  }))</pre> | `[]` | no |
 | autoscaling\_enabled | Creates an autoscaler for the managed instance group | `string` | `"false"` | no |
 | autoscaling\_lb | Autoscaling, load balancing utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#load_balancing_utilization | `list(map(number))` | `[]` | no |
 | autoscaling\_metric | Autoscaling, metric policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#metric | <pre>list(object({<br>    name   = string<br>    target = number<br>    type   = string<br>  }))</pre> | `[]` | no |

diff --git a/modules/mig_with_percent/variables.tf b/modules/mig_with_percent/variables.tf
@@ -177,8 +177,11 @@ variable "autoscaling_mode" {
 
 variable "autoscaling_cpu" {
   description = "Autoscaling, cpu utilization policy block as single element array. https://www.terraform.io/docs/providers/google/r/compute_autoscaler.html#cpu_utilization"
-  type        = list(map(number))
-  default     = []
+  type = list(object({
+    target            = number
+    predictive_method = string
+  }))
+  default = []
 }
 
 variable "autoscaling_metric" {