Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add gpu node autoscaling support (#807) #944

Merged
merged 9 commits into from
Jul 9, 2021
Merged

feat!: add gpu node autoscaling support (#807) #944

merged 9 commits into from
Jul 9, 2021

Conversation

JamesTimms
Copy link
Contributor

@JamesTimms JamesTimms commented Jun 30, 2021 •
edited
Loading

  • add gpu node autoscaling support

I haven't added this for any other modules yet as I only need it for beta-private-cluster. If you're happy with the change I'll make it for other modules where it's needed.

edit: I've now read the CONTRIBUTING.md guide and have updated my PR 🔨

  cluster_autoscaling = {
    enabled             = true
    autoscaling_profile = "BALANCED"
    min_cpu_cores       = 1
    max_cpu_cores       = 100
    min_memory_gb       = 1
    max_memory_gb       = 1000
    gpu_resources = [{
      resource_type = "nvidia-tesla-t4"
      minimum       = 1
      maximum       = 3
    }]
  }

feature: add gpu node autoscaling support (terraform-google-modules#807)
129116c 
* add gpu node autoscaling support for top level module

* add gpu node autoscaling support for beta-private-cluster module
@JamesTimms JamesTimms requested review from bharathkkb, Jberlinsky and a team as code owners June 30, 2021 15:26
@comment-bot-dev
Copy link

comment-bot-dev commented Jun 30, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

James Timms added 3 commits June 30, 2021 16:47
bharathkkb
bharathkkb requested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @JamesTimms

autogen/main/variables.tf.tmpl Outdated
Comment on lines 253 to 254
max_memory_gb = number
gpu_resources = list(object({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tf fmt lint error is possibly due to this

Suggested change
max_memory_gb = number
gpu_resources = list(object({
max_memory_gb = number
gpu_resources = list(object({

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that originally but no luck. I've now moved the object all on one line like other object definitions.

examples/node_pool/variables.tf Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feature: add gpu node autoscaling support (#807) feat!: add gpu node autoscaling support (#807) Jul 1, 2021
@bharathkkb
Copy link
Member

We will also need a small upgrade guide like this showing gpu_resources set to [] to retain previous functionality if they have set cluster_autoscaling

James Timms and others added 3 commits July 4, 2021 11:05
feature: add gpu node autoscaling support for all modules (terraform-…
5f5dbf6 
…google-modules#807)

* Format gpu_resource to meet linter requirements
* Update examples/node_pool/
@JamesTimms
Merge branch 'master' into feature/807-gpu-limits
d541bf1
feature: add gpu node autoscaling support for all modules (terraform-…
bfa8bf4 
…google-modules#807)

* Add v16.0 upgrade guide
* Update node_pool test to specify `gpu_resources`
@JamesTimms JamesTimms requested a review from bharathkkb July 4, 2021 12:28
bharathkkb
bharathkkb approved these changes Jul 6, 2021
View reviewed changes
docs/upgrading_to_v16.0.md Outdated Show resolved Hide resolved
docs/upgrading_to_v16.0.md Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit e53a949 into terraform-google-modules:master Jul 9, 2021
@release-please release-please bot mentioned this pull request Jul 9, 2021
Merged
@max-sixty max-sixty mentioned this pull request Nov 16, 2021
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@JamesTimms @bharathkkb
feat!: add gpu node autoscaling support (terraform-google-modules#807) (
3a7ef86 
terraform-google-modules#944)

* feature: add gpu node autoscaling support (terraform-google-modules#807)

* add gpu node autoscaling support for top level module

* add gpu node autoscaling support for beta-private-cluster module

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* add gpu node autoscaling support for all modules

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* updater example/node_pool cluster_autoscaling var to work with
  gpu_resources

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* fix example/node_pool formatting error

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* Format gpu_resource to meet linter requirements
* Update examples/node_pool/

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* Add v16.0 upgrade guide
* Update node_pool test to specify `gpu_resources`

* feature: add gpu node autoscaling support for all modules (terraform-google-modules#807)

* updates upgrade guide

Co-authored-by: Bharath KKB <[email protected]>

Co-authored-by: Bharath KKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesTimms @comment-bot-dev @bharathkkb