feat!: Add support for enable_l4_ilb_subsetting flag

[Jberlinsky]

Adds support for the google_container_cluster enable_l4_ilb_subsetting flag, which is particularly useful for clusters that require more than 250 total Nodes and build ILBs.

Note that enable_l4_ilb_subsetting is only supported in google-beta >= 3.63.0. Minimum module versions are bumped in accordance with this version change.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[Jberlinsky]

@bharathkkb @morgante @terraform-google-modules/cft-admins this is ready for review :)

[bharathkkb]

Thanks for the PR @Jberlinsky
Since we are bumping min provider versions this will be a breaking change.

[gauravkr19]

Hi @Jberlinsky @bharathkkb

After this commit - 7531f90,
I am getting the following error:

Error: Error waiting for creating GKE cluster: Failed to create cluster

on .terraform/modules/jenkins-gke/modules/beta-public-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
22: resource "google_container_cluster" "primary" {

Is the issue because of this Change or global issue with GKE
https://status.cloud.google.com/incidents/sqeWSRmcrJZyE2zSrJ74

Appreciate any help on this.

[bharathkkb]

Hi @gauravkr19
Our integration tests which spins up the clusters passed and this flag is false by default. I am inclined to say it is not related to this change. If you are able to reproduce, please open an issue with that and we can debug further.

[gauravkr19]

Thanks @bharathkkb for the quick response.

Can get the cluster up now, must be due to the outage at that point of time(tried 3 times).

By the way, I am implementing the jenkins-pipeline from below article and its working with terraform 0.12.24.
Will have to update the terraform version soon.
https://cloud.google.com/architecture/managing-infrastructure-as-code-with-terraform-jenkins-and-gitops