-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-repo support for Config Sync #872
Merged
bharathkkb
merged 7 commits into
terraform-google-modules:master
from
unlimitedbits:configsync_multi_repo
May 17, 2021
Merged
Add multi-repo support for Config Sync #872
bharathkkb
merged 7 commits into
terraform-google-modules:master
from
unlimitedbits:configsync_multi_repo
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlimitedbits
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
April 20, 2021 19:14
Thanks for the PR! 🚀 |
@bharathkkb Thoughts? |
bharathkkb
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Merged
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…es#872) * Add multi-repo support for Config Sync * Run make build * increase wait time for configsync api * Update modules/k8s-operator-crd-support/main.tf Co-authored-by: Bharath KKB <[email protected]> * Enhance wait_for_configsync_api step Co-authored-by: Morgante Pell <[email protected]> Co-authored-by: Bharath KKB <[email protected]> Co-authored-by: Morgante Pell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds support for the multi-repo setup for config sync (https://cloud.google.com/kubernetes-engine/docs/add-on/config-sync/how-to/multi-repo).
Furthermore, it adds the configRev property to the existing ConfigManagement resource (https://cloud.google.com/architecture/safe-rollouts-with-anthos-config-management#use_git_commits_or_tags).
The PR is fully backward compatible to the current behavior of the modules.