Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-repo support for Config Sync #872

Merged

Conversation

unlimitedbits
Copy link
Contributor

@unlimitedbits unlimitedbits commented Apr 20, 2021

Hi,

this PR adds support for the multi-repo setup for config sync (https://cloud.google.com/kubernetes-engine/docs/add-on/config-sync/how-to/multi-repo).
Furthermore, it adds the configRev property to the existing ConfigManagement resource (https://cloud.google.com/architecture/safe-rollouts-with-anthos-config-management#use_git_commits_or_tags).

The PR is fully backward compatible to the current behavior of the modules.

@unlimitedbits unlimitedbits requested review from bharathkkb, Jberlinsky and a team as code owners April 20, 2021 19:14
@comment-bot-dev
Copy link

comment-bot-dev commented Apr 20, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

@bharathkkb Thoughts?

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

modules/k8s-operator-crd-support/main.tf Outdated Show resolved Hide resolved
modules/k8s-operator-crd-support/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 23da103 into terraform-google-modules:master May 17, 2021
@release-please release-please bot mentioned this pull request May 17, 2021
@unlimitedbits unlimitedbits deleted the configsync_multi_repo branch May 17, 2021 21:28
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…es#872)

* Add multi-repo support for Config Sync

* Run make build

* increase wait time for configsync api

* Update modules/k8s-operator-crd-support/main.tf

Co-authored-by: Bharath KKB <[email protected]>

* Enhance wait_for_configsync_api step

Co-authored-by: Morgante Pell <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: Morgante Pell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants